Fix repeated unary minus on long lines collapsing into a comment#1076
Merged
JohnnyMorganz merged 2 commits intomainfrom Mar 7, 2026
Merged
Fix repeated unary minus on long lines collapsing into a comment#1076JohnnyMorganz merged 2 commits intomainfrom
JohnnyMorganz merged 2 commits intomainfrom
Conversation
When a chain of unary minus operators exceeded the column width, the hanging expression formatter would strip parentheses and produce output like `-----5`, which Lua interprets as a comment. The normal expression formatter already had protection against this, but the hanging path did not. Extract the double-minus parenthesisation logic into a shared helper `parenthesise_double_minus` and call it from both code paths. Fixes #1075
…eature/unary-minus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a chain of unary minus operators exceeded the column width, the hanging expression formatter would strip parentheses and produce output like
-----5, which Lua interprets as a comment. The normal expression formatter already had protection against this, but the hanging path did not.Extract the double-minus parenthesisation logic into a shared helper
parenthesise_double_minusand call it from both code paths.Fixes #1075