Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WoW front-end treats API network errors as empty responses #318

Closed
toolness opened this issue Jul 22, 2020 · 0 comments · Fixed by #386
Closed

WoW front-end treats API network errors as empty responses #318

toolness opened this issue Jul 22, 2020 · 0 comments · Fixed by #386

Comments

@toolness
Copy link
Contributor

Sydney just ran her development environment but her server immediately crashed because her .env file was out of date... However, this caused the front-end to behave in an odd way: when accessing property pages, instead of saying there was a network error, WoW showed her the "no registration for that BBL" page, implying that the problem was with HPD's data or the tenant's landlord, rather than the network!

Instead, the front-end code should show some kind of page indicating that a network error occurred.

@toolness toolness added this to the Technical Debt Cleanup milestone Jul 22, 2020
@sraby sraby removed this from the Technical Debt Cleanup milestone Aug 6, 2020
toolness added a commit that referenced this issue Aug 10, 2020
Fixes #384. Fixes #318. Also factors out a `<NetworkErrorMessage>` component to make things more DRY.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants