Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: Add linktype name #11584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

output: Add linktype name #11584

wants to merge 1 commit into from

Conversation

jlucovsky
Copy link
Contributor

@jlucovsky jlucovsky commented Jul 30, 2024

Continuation of #11564

Issue: 6954

This commit adds the linktype name to the output stream. The name is determined from the pcap utility function pcap_datalink_val_to_name

Link to ticket: https://redmine.openinfosecfoundation.org/issues/6954

Describe changes:

  • Include the linktype name alongside linktype
  • Update the schema with linktype_name

Updates:

  • Rebase
  • Expanded linktype name validation in s-v tests ensuring that testing on 6 and 7 continues to pass.

Provide values to any of the below to override the defaults.

SV_BRANCH=OISF/suricata-verify#1996

Issue: 6954

This commit adds the linktype name to the output stream. The name is
determined from the pcap utility function pcap_datalink_val_to_name
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (da1645b) to head (2bb32d0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11584      +/-   ##
==========================================
- Coverage   82.50%   82.49%   -0.02%     
==========================================
  Files         923      923              
  Lines      248721   248724       +3     
==========================================
- Hits       205215   205175      -40     
- Misses      43506    43549      +43     
Flag Coverage Δ
fuzzcorpus 60.47% <66.66%> (-0.04%) ⬇️
livemode 18.63% <0.00%> (+<0.01%) ⬆️
pcap 44.07% <0.00%> (+0.01%) ⬆️
suricata-verify 61.76% <66.66%> (-0.02%) ⬇️
unittests 59.07% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 21775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants