dcerpc/tcp: add frames support #11678
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frames of the following types have been added for toserver direction: 1. Pdu: The entire Protocol Data Unit 2. Hdr: Header of the request 3. Data: PDU data Feature 4904
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11678 +/- ##
==========================================
- Coverage 82.61% 77.64% -4.98%
==========================================
Files 919 919
Lines 248997 248953 -44
==========================================
- Hits 205717 193291 -12426
- Misses 43280 55662 +12382
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 22289 |
catenacyber
reviewed
Sep 3, 2024
| @@ -997,6 +1008,10 @@ impl DCERPCState { | |||
| } | |||
| parsed = self.bytes_consumed; | |||
|
|
|||
| let _hdr = Frame::new(flow, &stream_slice, &cur_i, parsed as i64, DCERPCFrameType::Hdr as u8, None); | |||
|
What is expected out of this draft ? Just to keep as a reminder and rebase once the blocker is merged ? |
yes. There's a chain of blockers in dcerpc work. |
|
My advice is to do a draft PR with all the commits, and then a regular PR with just the first commits ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/4904
SV_BRANCH=OISF/suricata-verify#2024
Note: This is Blocked by #11675. Currently, it is incorrect for fragmented data. The buffering happens in the input handler with a new allocation every time. However, the
FrameAPI expects pointer to the stream buffer which is available only with the current input.TODO: