Improve GDBM_File #18435
Merged
Improve GDBM_File #18435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements new functions and improves compatibility with new versions of GDBM. * ext/GDBM_File/GDBM_File.xs: Define interface methods for functions in newer GDBM versions. (GDBM_version): New static method. Return the version number (string in scalar, array of numbers in list context). Provide heurisics for determining the library version for GDBM prior to 1.9. (gdbm_close): Propagate return value from the library call. (gdbm_DESTROY): Croak if closing the database fails. (gdbm_UNTIE): New method. (gdbm_FETCH): Check database validity. Croak if gdbm_fetch returns error (except GDBM_ITEM_NOT_FOUND). (gdbm_STORE,gdbm_DELETE): Likewise. (gdbm_FIRSTKEY,gdbm_NEXTKEY): Likewise. (gdbm_EXISTS): Check database validity. (gdbm_errno): New function. (gdbm_syserrno): New function. (gdbm_strerror): New function. (gdbm_clear_error): New function. (gdbm_needs_recovery): New function. (gdbm_recover): New function. (gdbm_count): New function. * ext/GDBM_File/typemap (gdbm_count_t): Map to T_COUNT. * ext/GDBM_File/GDBM_File.pm: Document everything. Raise $VERSION. * MANIFEST: Update. * AUTHORS: Update.
Leont
reviewed
Dec 24, 2020
Leont
reviewed
Dec 24, 2020
tonycoz
reviewed
Jan 6, 2021
tonycoz
reviewed
Jan 6, 2021
tonycoz
reviewed
Jan 6, 2021
* ext/GDBM_File/GDBM_File.xs (rcvr_errfun): Use dTHX (gdbm_GDBM_version): Don't declare package. * ext/GDBM_File/typemap: Map gdbm_count_t to T_UV. * ext/GDBM_File/t/count.t: Use File::Temp to create db in a temporary directory. * ext/GDBM_File/t/fatal.t: Likewise. * ext/GDBM_File/t/opt.t: Likewise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements new functions and improves compatibility with new versions of GDBM.
ext/GDBM_File/GDBM_File.xs: Define interface methods for
functions in newer GDBM versions.
(GDBM_version): New static method. Return the version number
(string in scalar, array of numbers in list context). Provide
heurisics for determining the library version for GDBM prior
to 1.9.
(gdbm_close): Propagate return value from the library call.
(gdbm_DESTROY): Croak if closing the database fails.
(gdbm_UNTIE): New method.
(gdbm_FETCH): Check database validity. Croak if gdbm_fetch returns
error (except GDBM_ITEM_NOT_FOUND).
(gdbm_STORE,gdbm_DELETE): Likewise.
(gdbm_FIRSTKEY,gdbm_NEXTKEY): Likewise.
(gdbm_EXISTS): Check database validity.
(gdbm_errno): New function.
(gdbm_syserrno): New function.
(gdbm_strerror): New function.
(gdbm_clear_error): New function.
(gdbm_needs_recovery): New function.
(gdbm_recover): New function.
(gdbm_count): New function.
ext/GDBM_File/typemap (gdbm_count_t): Map to T_COUNT.
ext/GDBM_File/GDBM_File.pm: Document everything. Raise $VERSION.
MANIFEST: Update.
AUTHORS: Update.