Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Prettier reformatting #5191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025
Merged

Prettier reformatting #5191

merged 3 commits into from
May 16, 2025

Conversation

andyleejordan
Copy link
Member

I wonder if this will break GitHub.

@Copilot Copilot AI review requested due to automatic review settings May 15, 2025 21:32
@andyleejordan andyleejordan requested a review from a team as a code owner May 15, 2025 21:32
@andyleejordan andyleejordan added the Ignore Exclude from the changelog. label May 15, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies Prettier reformatting across various files for improved consistency and style. Key changes include:

  • Restructuring JSON arrays and simplifying YAML string formats.
  • Reformatting Markdown documentation for consistent list and table layouts.
  • Adjusting build pipeline files with standardized quotes and glob patterns.

Reviewed Changes

Copilot reviewed 60 out of 60 changed files in this pull request and generated no comments.

Show a summary per file
File Description
examples/.vscode/tasks.json Reformatted shell "args" arrays into a more concise, inline style.
examples/.vscode/settings.json Removed trailing commas and adjusted indentation in JSON.
docs/troubleshooting.md Reformatted lists and links for consistent Markdown styling.
docs/preview_to_stable_changelog.md Added spacing/newlines for clearer release note separation.
docs/development.md / docs/community_snippets.md / docs/azure_data_studio/README.md General markdown reformatting for improved readability.
SECURITY.md, README.md, CHANGELOG.md Consistent reformatting across documentation files.
.pipelines/vscode-powershell-Official.yml / .github/workflows/ci-test.yml Standardized YAML quoting and glob pattern usage.
.git-blame-ignore-revs Added ignore settings for Prettier reformat commits.

@andyleejordan
Copy link
Member Author

@SeeminglyScience @JustinGrote any files we don't want the Prettier formatting applied to?

@andyleejordan
Copy link
Member Author

Ok the commit to add the rebase ignore file will need to come post-merge as all of GitHub rebase-merge and squash-merge both result in a new commit, and I don't want to do a merge-merge.

@andyleejordan
Copy link
Member Author

Was not worth running it across Markdown.

@JustinGrote
Copy link
Collaborator

Only thing I can think is for files that will have their own vscode formatters, might end up in a back-and-forth fight between prettier and format-on-save, so we just have to keep an eye out for that in PRs after this.

Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Which cannot be set in .editorconfig.
Also remove old workaround for NPM.
@andyleejordan
Copy link
Member Author

Only thing I can think is for files that will have their own vscode formatters, might end up in a back-and-forth fight between prettier and format-on-save, so we just have to keep an eye out for that in PRs after this.

That was exactly what I ran into with Markdown. So it's configured and run only against the files it's set to be used for.

@andyleejordan andyleejordan merged commit e866df3 into main May 16, 2025
8 of 11 checks passed
@andyleejordan andyleejordan deleted the prettier branch May 16, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ignore Exclude from the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants