Added test case and fix for cython pure python import#2063
Merged
staticdev merged 2 commits intoPyCQA:mainfrom Dec 27, 2022
Merged
Added test case and fix for cython pure python import#2063staticdev merged 2 commits intoPyCQA:mainfrom
staticdev merged 2 commits intoPyCQA:mainfrom
Conversation
Contributor
Author
|
Added fix for the test case that fixes #2062 |
Collaborator
|
@jtoledo1974 thank you for the fix. Just curious, in your first commit adding the test it does not fail in CI. It should, right? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2063 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 38 38
Lines 3084 3084
Branches 745 745
=======================================
Hits 3047 3047
Misses 26 26
Partials 11 11 |
Contributor
Author
In my fork of isort from master, the first commit that added the test was failing (it was turning the import into a cimport). With the second commit that adds the fix the test does not fail. I'm not sure if that is what you were asking, though. |
staticdev
approved these changes
Dec 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a test case demostrating the issue. I'll try to produce a patch as well.