Conversation
|
Oh sorry, that's likely because noone approved the pending workflow runs on my PR, so only DeepSource ever ran, but the other CI never did. |
|
FYI: I did some work to get deps in this repo up-to-date with CI passing on a separate fork matthewhughes934/isort-fork@1326160...16f242a (separate fork because I wanted to make a bunch of PRs in my repo with CI runs, but found it difficult with just 'forking' in github since it target every PR on this repo by default) |
|
@Helveg or @matthewhughes934 Could you review this before I merge it? @matthewhughes934 Feel free to create PRs for some of those changes. Ideally with multiple smaller scoped PRs as I'm still getting used to this codebase :) |
I have a chain of branches ready to go, they update deps to nearly up to date (up to date as of the day I originally made the commits, so maybe 1 month out of date) and ends with adding
|
Error that wasn't caught correctly in the CI of #2283
Let's see if this passes CI or if I need to add more fixes :)