Ensure that split_on_trailing_comma works with as imports

[DanielNoord]

Closes #2338

Took the tests as recommended in #2339

I don't think we should fix the tests by disabling the new profile flag, that would mean that our tests work but anybody using the profile would still get broken imports.
Instead, let's try to fix config.split_on_trailing_comma itself. I believe this does this.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (4ae58fa) to head (b96c0ea).
Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2340   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files          40       40           
  Lines        3096     3096           
  Branches      787      787           
=======================================
  Hits         3069     3069           
  Misses         15       15           
  Partials       12       12           

[matthewhughes934]

what's expected for multiple as imports an a trailing comma, e.g. from lib import (a as b, c as d,)?

from lib import a as b
from lib import c as d

or

from lib import (
    a as b,
    c as d,
)

[DanielNoord]

Current code will do:

from lib import a as b
from lib import c as d

[staticdev]

@DanielNoord this Django integration test still failimg, did you have time to check if it is related or not to these black changes?

[DanielNoord]

Like I told you in the message: by changing the black style django is no longer conformant. The tests will fail until we release and they reformat their repository.

[staticdev]

@DanielNoord ok, then we can temporarily disable it and put a comment to re-enable when they upgrade to 6.0.0+

[DanielNoord]

@staticdev There we go.

I double checked and the offending line is:
https://github.com/django/django/blob/ec8cbea91ed6362d43298caa43f3d868452f7efa/django/db/backends/postgresql/compiler.py#L6

django does indeed use the black profile:
https://github.com/django/django/blob/ec8cbea91ed6362d43298caa43f3d868452f7efa/pyproject.toml#L61
Which surprised me considering there is a django profile as well...

I think this is fine to merge now :)

[staticdev]

@DanielNoord LGTM, thanks.

[nessita]

Thank you for considering Django in this change. As you can see in the linked PR #19109 this is forcing a reformat which does not seem correct. What do you think?

- from django.db.models.sql.compiler import SQLUpdateCompiler
+ from django.db.models.sql.compiler import (
+     SQLUpdateCompiler,
+ )

[DanielNoord]

That was raised as an issue in #2352.

Current status is: we're still determining whether this is a bug and are trying to see if we can provide a fix.