Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2359 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 40 40
Lines 3101 3101
Branches 680 680
=======================================
Hits 3075 3075
Misses 15 15
Partials 11 11 |
DanielNoord
left a comment
There was a problem hiding this comment.
Thanks! One question about the ignores
|
The fact that |
|
@cclauss @DanielNoord to be honest, I am not very familiar with DeepSource, it was there since forever. Not sure it is a modern solution anymore. Does any of you have opinions on it already? |
|
I'm not a fan of DeepSource for Python (I find it silent but then opaque) but I hear it is quite useful for other languages. |
|
I would also be okay with removing it! |
DanielNoord
left a comment
There was a problem hiding this comment.
I would probably open an issue for the follow up on the ignores, but other than that LGTM!
05c67e6 to
ccff6bf
Compare
|
Failing GitHub Actions tests fixed in: |
|
@cclauss after the other merges, this one needs a manual rebase. |
DanielNoord
left a comment
There was a problem hiding this comment.
Still LGTM!
Thanks @cclauss
|
What up with the Windows tests? |
|
A broken test added in #2331 You're not having a lot of luck with this PR, sorry! I'll leave it to @staticdev to decide how they want to resolve this. |
1ebf17c to
a9ff147
Compare
As suggested at #2353 (review) let's add the
rufflinter.