Merged
Conversation
Migrate from reflection to unsafeSubscribe as per discussion at ReactiveX#676
Member
Author
|
With these changes I'm seeing non-deterministic failure of |
|
RxJava-pull-requests #937 FAILURE |
Member
Author
|
Problem appears to be related to the |
|
RxJava-pull-requests #938 FAILURE |
The blocking operators need to use 'subscribe', not 'unsafeSubscribe' since they need the SafeSubscriber behavior in the final subscribe step they perform. Renamed operators to BlockingOperator* for clarity and to match the Operation->Operator naming change.
Member
Author
|
The unit tests passed that were failing previously ... build is timing out on Quasar tests for some reason (though they work on our other build servers and locally). |
|
RxJava-pull-requests #940 ABORTED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate from reflection to unsafeSubscribe as per discussion at #676
All operators are migrated to using
unsafeSubscribeinstead of relying on their package to avoidSafeSubscriberwrapping.