Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Operator debounce2#1094

Merged
benjchristensen merged 2 commits intoReactiveX:masterfrom
akarnokd:OperatorDebounce2
Apr 30, 2014
Merged

Operator debounce2#1094
benjchristensen merged 2 commits intoReactiveX:masterfrom
akarnokd:OperatorDebounce2

Conversation

@akarnokd
Copy link
Member

Operator Debounce again with improvements as discusssed in #1075

For Issue #1060

@akarnokd akarnokd mentioned this pull request Apr 25, 2014
57 tasks
@cloudbees-pull-request-builder

RxJava-pull-requests #1004 FAILURE
Looks like there's a problem with this pull request

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really inefficient operator! The use case requires this behavior, but every single onNext will cause a new Observable, Subscriber, and CompositeSubscription. Not pretty.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many operators that subscribe to an observable on each onNext call.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I know ... I just wish I could think of a way to make it less expensive!

@benjchristensen benjchristensen merged commit 45d0eaf into ReactiveX:master Apr 30, 2014
@akarnokd akarnokd deleted the OperatorDebounce2 branch April 30, 2014 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants