Change RxRingBuffer Queue Usage#1496
Merged
benjchristensen merged 2 commits intoReactiveX:masterfrom Jul 23, 2014
Merged
Conversation
benjchristensen
added a commit
that referenced
this pull request
Jul 23, 2014
Change RxRingBuffer Queue Usage
|
RxJava-pull-requests #1428 SUCCESS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are non-determinisitic failures in the
offerbehavior of the JCTools code that I don't understand yet, so reverting toSynchronizedQueuewhich does not show the problem. The performance hit is not huge, it's even better in some cases.This should result in more object allocation though, so that needs to be tested (I'll do so along with Netflix production testing).