Fix the compose covariance#1577
Merged
benjchristensen merged 2 commits intoReactiveX:masterfrom Aug 14, 2014
Merged
Conversation
|
RxJava-pull-requests #1487 FAILURE |
Member
Author
|
Although it's not elegant, it's the best way I can find. Any suggestion? |
|
RxJava-pull-requests #1488 SUCCESS |
Contributor
|
Less variance is more elegant IMHO. |
Contributor
|
I was able to git rid of the |
Member
|
@abersnaze That's another layer of object allocation and subscription ... what do we gain with this? Is |
benjchristensen
added a commit
that referenced
this pull request
Aug 14, 2014
Fix the compose covariance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the return type of
composefromObservable<? extends R>toObservable<R>. The reason is that if returningObservable<? extends R>, the following codes won't work in Java:we have to write:
Because we cannot assign
Observable<? extends R>to aObservable<R>variable, we should avoid to returnObservable<? extends R>, otherwise the API will be inconvenient.