Fixed the issues of takeLast(items, 0) and null values#413
Merged
benjchristensen merged 3 commits intoReactiveX:masterfrom Oct 9, 2013
Merged
Fixed the issues of takeLast(items, 0) and null values#413benjchristensen merged 3 commits intoReactiveX:masterfrom
benjchristensen merged 3 commits intoReactiveX:masterfrom
Conversation
|
RxJava-pull-requests #319 SUCCESS |
|
RxJava-pull-requests #321 SUCCESS |
Member
|
Merging as this seems correct ... but I question whether we need any of this synchronization in here since this operator would never be multi-threaded. It can count on the Rx contract to have sequential onNext events. Thus I wonder if the performance hit of all this synchronization is a concern or necessary. I'm favoring functionality and merging now ... but something to consider for the future. |
benjchristensen
added a commit
that referenced
this pull request
Oct 9, 2013
Fixed the issues of takeLast(items, 0) and null values
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Fixed the issues of takeLast(items, 0) and null values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
There are two issues about
takeLast#85 #140. The essential cause isLinkedBlockingDeque.takeLastin RxJava will throw an exception when count == 0, asLinkedBlockingDequerejects count <= 0. However, in c#, TakeLast with 0 count is valid. The following codes is OK in C# (no exception and do nothing):LinkedBlockingDeque requires the elements can not be null but an observable can emit a null value.
I used
ReentrantLockandLinkedListto replaceLinkedBlockingDeque. Please take a look. Thanks.