Adding collect method to Scala Observable#421
Conversation
|
RxJava-pull-requests #329 SUCCESS |
|
@samuelgruetter can you review this and comment as it related to Scala? @madnl thanks for getting involved. Once review with Samuel, can you please rebase this on top of the recent changes so it can merge without conflicts again? Right now it conflicts as there was a large set of Scala changes that just got merged to master. |
|
Yes, adding methods which are in Scala collections but not in RxJava is one of the points which are still on the TODO list. |
|
This conflicts so can't be cleanly merged. Can unit tests be added and a new pull request submitted after rebasing changes from master? |
I think it's a good idea to add a
collectmethod analogous with the one in the Scala collection library. It was simplest to implement it using a combination offilter&map.If you find any major disadvantages with this please chime in.