Scala Adaptor Details

[samuelgruetter]

With #503, some files were lost, so I added them again, and I also fixed many other details. There are no changes in functionality/inheritance, only "cosmetics". Except samuelgruetter@8567fcb : @headinthebox could you please confirm this one-line change?

[benjchristensen]

@headinthebox @samuelgruetter Please confirm the two of you agree on this and I'll merge.

[cloudbees-pull-request-builder]

RxJava-pull-requests #437 SUCCESS
This pull request looks good

[headinthebox]

Looks good.

[headinthebox]

Found a small bug (copy & paste)

object PublishSubject {
def apply[T](value: T): PublishSubject[T] = {
new PublishSubjectT
}
}

We need to add as well (and have the above call this one). I use the above to force type inference

object PublishSubject {
def applyT: PublishSubject[T] = {
new PublishSubjectT
}
}

[samuelgruetter]

2x exactly the same?
(btw please indent code by 4 spaces ;-) )

[samuelgruetter]

@headinthebox I still don't understand what you mean with this comment

[headinthebox]

This is a trick we often use in C#. You pass in a dummy "witness" of type T to help the compiler infer types. If you say PublishSubject() it will infer PublishSubject[Nothing] and you are forced tp write PublishSubjectT. I never want to write a concrete type anywhere.

[samuelgruetter]

With the current code

object PublishSubject {
  def apply[T](): PublishSubject[T] = {
    new PublishSubject[T](rx.subjects.PublishSubject.create())
  }
}

we can do the following:

val s1 = PublishSubject[Int]() // inferred type of s1: PublishSubject[Int]
val s2 = PublishSubject()      // inferred type of s2: PublishSubject[Nothing]
val s3: PublishSubject[Int] = PublishSubject() // also works

What else do you want to be possible?

[samuelgruetter]

So you want to write

val s4 = PublishSubject(0)

because you prefer writing 0 over writing Int?
That's never done in Scala and looks very weird to me...