Merged
Conversation
deadshotsb
suggested changes
Jul 2, 2020
DataStructures/Graphs/Kruskal.java
Outdated
| @@ -0,0 +1,94 @@ | |||
| package Kruskal; | |||
Member
There was a problem hiding this comment.
The repository is for educational purpose and therefore it will be great if you could add a description of your problem.
Member
|
Great work, looks good but it will be better if you could add the requested addons |
Contributor
Author
|
Thank you for your reply, I have added a new commit giving the context missing. Could you please check it? |
deadshotsb
suggested changes
Jul 6, 2020
DataStructures/Graphs/Kruskal.java
Outdated
| //The graph needs to be connected, because if there are nodes impossible to reach, there are no edges that could connect every node in the graph. | ||
| //KA is a Greedy Algorithm, because edges are analysed based on their weights, that is why a Priority Queue is used, to take first those less weighted. | ||
| //This implementations below has some changes compared to conventional ones, but they are explained all along the code. | ||
| //In case you need to know anyhing else, I would be willing to answer all your doubts, you can contact me by https://www.linkedin.com/in/marcosvillacanas/ |
Member
There was a problem hiding this comment.
@MarcosVillacanas kindly remove the reference to any personal link, you can add a reference for the algo though
Member
|
@MarcosVillacanas otherwise there are no issues with the PR |
Contributor
Author
|
Ready to go :) |
deadshotsb
approved these changes
Jul 7, 2020
|
Thank you
Le mar. 7 juil. 2020 à 09:42, Sombit Bose <notifications@github.com> a
écrit :
… Merged #1352 <#1352> into
master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1352 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/APHVX6JQKQZJBUV4U3F5MXTR2LUYLANCNFSM4OAPQFJQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kruskal algorithm was missing.
It is used to find the minimum spanning tree.
My code simplifies other implementations, the algorithm itself is just composed of one method with less than 25 lines of code commented.