Conversation
|
I was able to fix the error thrown by the code-formatter-check but I can't get it to pass the prettier-check. Could someone help me out? |
There was a problem hiding this comment.
Thanks for your contribution, please update the documentation according to Java docs standard.
refer to the documentation of this file in case you need any help regarding documentation.
also add tests
|
Thanks for the feedback. I've reformatted the documentation and I've implemented tests to validate that the numerical arguments are in range. |
|
I just created another pull request for a separate addition that kept failing on the "Prettier / prettier" check with the same error message you are getting. I fixed the issue by changing branch I was comitting from to be called master and it fixed it, hope this helps you. |
|
Thank you for this insight! I've tried it and it also solved the problem for me, see #2148 . I'll close this pull request & open an issue. |
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}.