update variable names for consistency using standard formula terms; #2223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix flake8 syntax errors; fix doctests;
ruppysuppy
suggested changes
Jul 22, 2020
|
I used side because that is what wikipedia uses in the formula, A = s^2. Reading the article closer, s is for side length, not just side. Change is in, thanks. |
cclauss
reviewed
Jul 22, 2020
| @@ -48,24 +48,24 @@ def area_square(side_length): | |||
| >>> area_square(10) | |||
| 100 | |||
| """ | |||
| return side_length * side_length | |||
| return pow(side_length, 2) | |||
There was a problem hiding this comment.
This adds function call overhead but let's let it slide.
cclauss
reviewed
Jul 22, 2020
|
|
||
|
|
||
| def area_parallelogram(base, height): | ||
| """ | ||
| Calculate the area of a parallelogram | ||
|
|
||
| >> area_parallelogram(10,20) | ||
| >>> area_parallelogram(10,20) |
cclauss
reviewed
Jul 22, 2020
| @@ -75,8 +75,8 @@ def area_trapezium(base1, base2, height): | |||
| """ | |||
| Calculate the area of a trapezium | |||
|
|
|||
| >> area_trapezium(10,20,30) | |||
| 450 | |||
| >>> area_trapezium(10,20,30) | |||
stokhos
pushed a commit
to stokhos/Python
that referenced
this pull request
Jan 3, 2021
…heAlgorithms#2223) * update variable names for consistency using standard formula terms; fix flake8 syntax errors; fix doctests; * tweak to variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix flake8 syntax errors;
fix doctests;
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.