Create fibonaci.py #866
Closed
Create fibonaci.py #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows 2 functions to find and print first 5 fibonacci numbers
poyea
requested changes
Jun 3, 2019
Changed the indentation to 4 Spaces
poyea
requested changes
Jun 5, 2019
There was a problem hiding this comment.
Although your code compiles, did you make a difference comparing to maths/fibonacci_sequence_recursion.py? (We kind of refrain from merging code that appears or, in some sense, the same into the repository. Otherwise, well, you could imagine.)
I suggest you change this into an iterative approach. Remember to write tests for your code (Perhaps you've forgotten this time; as said in Contribution Guidelines)!
Please consider changing it a little bit! Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows 2 functions to find and print first 5 fibonacci numbers