Fix the Python Syntax Error that is causing LGTM to fail #880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __elif__ in this solution will __never__ be executed.
|
I'm seeing the same thing for a pull request I submitted yesterday. I made the update in my branch, but it won't it still fails the LGTM check. Elif statement is in Project Euler/Problem 01/sol5.py |
|
The folks at LGTM tried to explain it to me but I do not understand their explanation. A real test runner would be preferable to LGTM. https://discuss.lgtm.com/t/tests-are-not-automatically-run-when-lgtm-yml-is-modified/1446/5 Also see #425 (comment) |
|
The solution, too, is incorrect. Problem statement is "Find the sum of all the multiples of 3 or 5 below 1000." |
print(sum(i if 0 in (i % 3, i % 5) else 0 for i in range(1000)))
233168 |
|
Thanks again, this is done by #882. I've pushed this to that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #425
The elif in the current solution will never be executed.