Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customizable severity levels #584

Merged
merged 8 commits into from
Jul 18, 2024

Conversation

reuvenharrison
Copy link
Collaborator

@reuvenharrison reuvenharrison commented Jul 17, 2024

This PR adds an option to customize severity levels.
This will replace "optional checks" and the --include-checks flag.

This feature was requested in this discussion: #572

@reuvenharrison reuvenharrison linked an issue Jul 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 98.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.19%. Comparing base (3fd2ca2) to head (ef15714).

Files Patch % Lines
internal/diff_flags.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   85.99%   87.19%   +1.19%     
==========================================
  Files         227      227              
  Lines       12976    10926    -2050     
==========================================
- Hits        11159     9527    -1632     
+ Misses       1404      991     -413     
+ Partials      413      408       -5     
Flag Coverage Δ
unittests 87.19% <98.85%> (+1.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reuvenharrison reuvenharrison merged commit 73a0f92 into main Jul 18, 2024
14 of 16 checks passed
@reuvenharrison reuvenharrison deleted the 583-make-severity-levels-customizable branch July 18, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make severity levels customizable
1 participant