-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking Change] Deprecation of 'compile_builtins' and removal in v5 #777
Comments
Quick question, what is the reason for this change? Is this to support the use-case where a user/team might want to pre-compile the builtins for their simulators to speed up test runs? I have nothing against the change, just curious why it's being made. |
There are both technical and tactical reasons. On the technical side, having separated commands/options to add VHDL and Verilog builtins (instead of overriding the same one) allows us to more easily share the features that are common, regardless of the language; or even using both in mixed-language desings. We avoid a VUnit class for Verilog. Note that On the tactical side, we want to better communicate VUnit's vision of the broader (open source) hardware verification ecosystem.
Some relevant references in this regard:
|
…do 2020 Xsim, ghdl simulations, and quartus simulations Squashed commit of the following: commit f693ec9 Author: Matthew Schiller <mschille@nrao.edu> Date: Fri May 26 14:29:03 2023 -0400 Fixes for size of sepa data and fix for I=I Q=I problem. commit a436eca Author: Matthew Schiller <mschille@nrao.edu> Date: Fri May 26 11:31:03 2023 -0400 Fix for xsims and projects commit 482b810 Author: Matthew Schiller <mschille@nrao.edu> Date: Fri May 26 10:41:59 2023 -0400 Removing types doc commit 73d2e66 Merge: 5d5aa2d 4eb6392 Author: Matthew Schiller <mschille@nrao.edu> Date: Fri May 26 10:34:01 2023 -0400 Merge remote-tracking branch 'origin/main' commit 5d5aa2d Author: Matthew Schiller <mschille@nrao.edu> Date: Fri May 26 10:31:23 2023 -0400 Possible fix for vunit simulations in newer GHDL? commit 4eb6392 Author: Matthew Schiller <mschille@nrao.edu> Date: Fri May 26 08:09:10 2023 -0400 Update .gitlab-ci.yml file commit e154111 Author: Matthew Schiller <mschille@nrao.edu> Date: Fri May 26 07:51:34 2023 -0400 Update .gitlab-ci.yml file to get ghdl version commit e868cac Author: Matthew Schiller <mschille@nrao.edu> Date: Fri May 26 07:41:45 2023 -0400 fix type errors commit 4071b36 Author: Matthew Schiller <mschille@nrao.edu> Date: Thu May 25 12:48:31 2023 -0400 Fix syntax errors in run.py commit aaab566 Author: Matthew Schiller <mschille@nrao.edu> Date: Thu May 25 12:45:02 2023 -0400 Fix to load numpy for all test benches in vunit ghdl commit 880f2da Author: Matthew Schiller <mschille@nrao.edu> Date: Thu May 25 12:39:29 2023 -0400 more python fixes commit f94c4dd Author: Matthew Schiller <mschille@nrao.edu> Date: Thu May 25 12:14:01 2023 -0400 Updating for vunit 5.0+ as per VUnit/vunit#777 commit a9c15ff Author: Matthew Schiller <mschille@nrao.edu> Date: Thu May 25 11:36:29 2023 -0400 Removed parts of fixed/float package that confuses GHDL commit b214ab5 Author: Matthew Schiller <mschille@nrao.edu> Date: Thu May 25 11:00:40 2023 -0400 Try 1241234123 to fix python commit 1ad5e1c Author: Matthew Schiller <mschille@nrao.edu> Date: Thu May 25 10:53:48 2023 -0400 MOre python issues... commit 507f926 Author: Matthew Schiller <mschille@nrao.edu> Date: Thu May 25 10:47:14 2023 -0400 Implemented version 4.7.0 changes as per VUnit/vunit#777 commit 352461f Author: Matthew Schiller <mschille@nrao.edu> Date: Thu May 25 10:41:39 2023 -0400 Ugh more typos commit 89ae7d6 Author: Matthew Schiller <mschille@nrao.edu> Date: Thu May 25 10:36:32 2023 -0400 Fix to include new fixed point files to work around vhdl 2008 compatability in Xsim commit d07430c Author: Matthew Schiller <mschille@nrao.edu> Date: Thu May 25 10:25:41 2023 -0400 Changing to vunit docker and runtime installing numpy and pytest
VUnit 5.0.0 is now the maintrack, and fixes for VUnit/vunit#777 are merged to master. Hence we do not need this workaround anymore. The only point of the "workaround" was to skip a deprecation warning printout. It should still work for users of older VUnit versions.
Option
compile_builtins
of methodsfrom_args
andfrom_argv
is to be removed in an upcoming release of VUnit. Until v4.7.0 (included), compile_builtins is enabled by default. Therefore, removing the option (thus, having it disabled by default), is a breaking change that will affect most users, particularly newcomers copying and pasting examples/tutorials. This issue contains guidelines to adapt the scripts.References:
VHDL only
Traditional procedure (until v4.6.0):
Recommended procedure with v4.7.0 (current
master
):Upcoming procedure with v5:
Verilog only
Traditional procedure (until v4.6.0):
Recommended procedure with v4.7.0 (current
master
):Upcoming procedure with v5:
Mixed language (VHDL and Verilog, or Verilog and VHDL)
Traditional procedure (until v4.6.0):
Recommended procedure with v4.7.0 (current
master
):Upcoming procedure with v5:
The text was updated successfully, but these errors were encountered: