Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
This repository was archived by the owner on Jun 8, 2021. It is now read-only.

fix(Compiler): show delete log only on tracked file#167

Merged
thetutlage merged 1 commit intoadonisjs:nextfrom
RomainForks:logging
Oct 22, 2019
Merged

fix(Compiler): show delete log only on tracked file#167
thetutlage merged 1 commit intoadonisjs:nextfrom
RomainForks:logging

Conversation

@RomainLanz
Copy link
Member

Proposed changes

Currently the logger logs everytime we delete a file, even when the file shouldn't be tracked (i.e: .git).

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@thetutlage thetutlage merged commit eeac245 into adonisjs:next Oct 22, 2019
@thetutlage
Copy link
Member

😊

@RomainLanz RomainLanz deleted the logging branch October 22, 2019 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants