Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

feat(server): added the ability to obtain instance http.createServer () for socket.io#165

Merged
thetutlage merged 4 commits intoadonisjs:developfrom
ntvsx193:develop
Jun 6, 2016
Merged

feat(server): added the ability to obtain instance http.createServer () for socket.io#165
thetutlage merged 4 commits intoadonisjs:developfrom
ntvsx193:develop

Conversation

@ntvsx193
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented May 19, 2016

Coverage Status

Coverage increased (+0.003%) to 98.95% when pulling 4d4d829 on ntvsx193:develop into d243383 on adonisjs:develop.

@iCodeForBananas
Copy link

@thetutlage Any idea when this will get merged? I am hoping to convert to Adonis very soon! :)

@thetutlage
Copy link
Member

Couple of changes here.

First

Can you rename the method getCreateServerInstance to getInstance, as it makes more sense when you call it as Server.getInstance().

Second

Please rename httpCreateServerInstance to httpInstance and define it to null inside constructor.

Finally it will be great to have some tests, where you can access the instance. It will be simple but makes the future changes more solid.

@coveralls
Copy link

coveralls commented Jun 4, 2016

Coverage Status

Coverage increased (+0.004%) to 98.951% when pulling 7d88883 on ntvsx193:develop into d243383 on adonisjs:develop.

@thetutlage thetutlage merged commit 8d221d0 into adonisjs:develop Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants