fix(storage): sanitize preview channel db filenames#16398
Open
2asoft wants to merge 1 commit intoanomalyco:devfrom
Open
fix(storage): sanitize preview channel db filenames#163982asoft wants to merge 1 commit intoanomalyco:devfrom
2asoft wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16396
Type of change
What does this PR do?
This fixes startup failures for preview builds when the channel contains
/.Preview builds use the git branch as the channel. That channel was being used directly in the local SQLite filename, so a channel like
foo/barproducedopencode-foo/bar.db. SQLite treated that as a nested path and startup failed withunable to open database file.This change sanitizes
/before building the database filename so preview channels still get isolated databases without creating invalid paths.How did you verify your code works?
packages/opencode/test/storage/db.test.tsbun test test/storage/db.test.tsbun test test/storage/db.test.ts test/storage/json-migration.test.ts/and verified the sanitized path isopencode-foo-bar.dbScreenshots / recordings
N/A
Checklist