fix(tui): fix broken /export toggling#16443
Merged
nexxeln merged 1 commit intoanomalyco:devfrom Mar 7, 2026
Merged
Conversation
nexxeln
approved these changes
Mar 7, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #16437
Type of change
What does this PR do?
/exportdialog toggling/selection does not work for terminals that use the kitty keyboard protocol (ex. vscode integrated terminal). This is because the dialog keybinding expects the"space"token for toggling while the vscode integreated terminal emits a" "token instead. We fixed this by addingif (evt.name === "space" || evt.name === " ")todialog-export-options.How did you verify your code works?
Tested on iTerm2, kitty, and the vscode integrated terminal and ran
bun test test/keybind.test.tsbun run typecheckbun turbo typecheckScreenshots / recordings
Before fix
Screen.Recording.2026-03-07.at.12.27.33.AM.mov
After fix
Screen.Recording.2026-03-07.at.12.50.48.AM.mov
Checklist