AVRO-3088: [C++] Export CMake package config file #3299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitjap
reviewed
Jan 22, 2025
wgtmac
added a commit
to wgtmac/iceberg-cpp
that referenced
this pull request
Jan 23, 2025
mkmkme
reviewed
Jan 23, 2025
mkmkme
reviewed
Jan 23, 2025
Fokko
reviewed
Jan 24, 2025
| # Boost 1.70 and above provide a BoostConfig.cmake package configuration file. | ||
| # It guarantees that Boost::system target exists if found. | ||
| # See https://cmake.org/cmake/help/latest/policy/CMP0167.html | ||
| find_package (Boost 1.70 REQUIRED CONFIG COMPONENTS system) |
There was a problem hiding this comment.
We don't set the Boost version in the Dockerfile: https://github.com/apache/avro/blob/main/share/docker/Dockerfile#L49
So that's good 👍
thiru-mg
approved these changes
Jan 26, 2025
mkmkme
reviewed
Jan 27, 2025
lang/c++/CMakeLists.txt
Outdated
| endif () | ||
|
|
||
| if (AVRO_BUILD_TESTS) | ||
| enable_testing() | ||
|
|
||
| macro (unittest name) | ||
| add_executable (${name} test/${name}.cc) | ||
| target_link_libraries (${name} avrocpp_s ${Boost_LIBRARIES} ${SNAPPY_LIBRARIES} ${ZLIB_LIBRARIES}) | ||
| target_link_libraries (${name} avrocpp_s Boost::system ZLIB::ZLIB $<$<TARGET_EXISTS:Snappy::snappy>:Snappy::snappy>) |
There was a problem hiding this comment.
Can't we use $<TARGET_NAME_IF_EXISTS:Snappy::snappy> here as well instead of $<$<TARGET_EXISTS:Snappy::snappy>:Snappy::snappy>?
There was a problem hiding this comment.
Yes, that's better. I have switched to use TARGET_NAME_IF_EXISTS. At the same time, the minimum CMake version has been bumped to 3.12 to use it: https://cmake.org/cmake/help/v3.12/release/3.12.html?highlight=target_name_if_exists#generator-expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Verifying this change
I have manually verified that the exported config file can be used by downstream projects like below:
Documentation