api: remove required flag of gatewayid in CreateStaticRouteCmd

[weizhouapache]

Description

This PR fixes #12782

it was added in the merge of 4.20 branch to 4.22 branch: 55ab7c5

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[rajujith]

@blueorangutan package

[blueorangutan]

@rajujith a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.61%. Comparing base (7aa0558) to head (1e85374).
⚠️ Report is 3 commits behind head on 4.22.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12786      +/-   ##
============================================
- Coverage     17.61%   17.61%   -0.01%     
  Complexity    15664    15664              
============================================
  Files          5917     5917              
  Lines        531402   531402              
  Branches      64971    64971              
============================================
- Hits          93596    93594       -2     
- Misses       427252   427254       +2     
  Partials      10554    10554              

Flag	Coverage Δ
uitests	3.70% <ø> (ø)
unittests	18.68% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17087

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[rajujith]

LGTM

This has now added a generic static route not tied to the private gateway.

[weizhouapache]

LGTM

This has now added a generic static route not tied to the private gateway.

thanks @rajujith

[blueorangutan]

[SF] Trillian test result (tid-15603)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53396 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12786-t15603-kvm-ol8.zip
Smoke tests completed. 146 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestListIdsParams>:teardown	Error	1.15	test_list_ids_parameter.py
test_01_snapshot_root_disk	Error	4.89	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	49.72	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	Error	49.72	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	Error	28.56	test_snapshots.py
test_01_snapshot_usage	Error	22.73	test_usage.py
test_01_vpn_usage	Error	1.08	test_usage.py

[sureshanaparti]

clgtm

[sureshanaparti]

@weizhouapache is this PR ready, any further changes?

[weizhouapache]

@weizhouapache is this PR ready, any further changes?

thanks @DaanHoogland @sureshanaparti for the review, @rajujith for the testing

I think it is ready for merge ?