Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content

Update datafusion dependency to 52.3.0#1425

Open
timsaucer wants to merge 3 commits intoapache:branch-52from
timsaucer:patch/52.3.0
Open

Update datafusion dependency to 52.3.0#1425
timsaucer wants to merge 3 commits intoapache:branch-52from
timsaucer:patch/52.3.0

Conversation

@timsaucer
Copy link
Member

Which issue does this PR close?

None

Rationale for this change

This PR only updates the datafusion dependency to 52.3.0.


// Re-export Apache Arrow DataFusion dependencies
pub use datafusion;
pub use datafusion::{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ive been seeing a lot of these changes across PRs, is there something we can run for the entire repo? or configure the linter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a change in the nightly cargo fmt, probably from the new rust release. If we do, then we'd need to turn off the group_imports and imports_granularity in rustfmt.toml. I suppose we could do that and just have it turned on in the pre-commit. That just means that any contributors who do have that turned on will end up with more formatting changes than others. Or we could take those out, but personally I think it does make the repo cleaner. What do you think?

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants