Update kvrocks.yaml#721
Merged
PragmaTwice merged 1 commit intoapache:unstablefrom Jul 8, 2022
kezhenxu94:patch-1
Merged
Conversation
PragmaTwice
approved these changes
Jul 8, 2022
Member
PragmaTwice
left a comment
There was a problem hiding this comment.
LGTM. BTW is there a suitable tag rather than a commit hash?
Member
Author
We haven't had a release 0.4.0 so for now we have to use a commit hash, we will manage to release 0.4.0 soon so you can change to |
Contributor
|
LGTM |
tisonkun
approved these changes
Jul 8, 2022
Member
Got it. Merging, thanks for you contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a dedicate GitHub actions for header check so this should be updated, and we don't recommend using
@mainso there is no unexpected behaviors when we have changes in our codebase.See apache/skywalking-eyes#123