-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-14371 Zk StatusHandler should know about dynamic zk config #1392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a first lookthrough, but it looks good so far!
solr/core/src/java/org/apache/solr/handler/admin/ZookeeperStatusHandler.java
Outdated
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/handler/admin/ZookeeperStatusHandler.java
Outdated
Show resolved
Hide resolved
solr/core/src/test/org/apache/solr/handler/admin/ZookeeperStatusHandlerTest.java
Outdated
Show resolved
Hide resolved
solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java
Outdated
Show resolved
Hide resolved
and remove server.X since they are covered elsewhere and too long to render
Add 'role' to output, if exists
Show dynamic reconfig Filter empty keys
solr/core/src/java/org/apache/solr/handler/admin/ZookeeperStatusHandler.java
Outdated
Show resolved
Hide resolved
…ynamic config host list
# Conflicts: # solr/CHANGES.txt
… of SolrZkClient Parsing /zookeeper config string now returns the ZkDynamicConfig object instead of a List<>
I was not happy with the Also fixed refGuide text, which still said that Solr supports dynamic reconfig. |
(cherry picked from commit 03363f4) with java11 -> java8 modifications
See https://issues.apache.org/jira/browse/SOLR-14371