Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-14371 Zk StatusHandler should know about dynamic zk config #1392

Merged
merged 18 commits into from
Apr 17, 2020

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented Mar 31, 2020

Copy link
Contributor

@HoustonPutman HoustonPutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a first lookthrough, but it looks good so far!

@janhoy janhoy marked this pull request as ready for review April 1, 2020 22:25
@janhoy
Copy link
Contributor Author

janhoy commented Apr 7, 2020

I was not happy with the ZkConfigDyn class inside SolrZkClient, so I am factoring it out into its own class ZkDynamicConfig which is passed to ZookeeperStatusHandler.getZkStatus() instead of the list.

Also fixed refGuide text, which still said that Solr supports dynamic reconfig.

@janhoy janhoy merged commit 03363f4 into apache:master Apr 17, 2020
@janhoy janhoy deleted the solr14371-zk-status branch April 17, 2020 14:30
janhoy added a commit that referenced this pull request Apr 17, 2020
(cherry picked from commit 03363f4)
with java11 -> java8 modifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants