GemfileLockResolver adjusted to exclude all specs when runtime dependencies are empty#208
Conversation
…encies are empty - regression test: Ruby library projects with no runtime dependencies do not include development dependencies
d429d13 to
7ef9083
Compare
|
@kezhenxu94 @wu-sheng this is done! |
|
@kezhenxu94 @wu-sheng I sent an email requesting to be added to the SkyWalking slack. 😸 |
|
@kezhenxu94 This is so cool! I am not sure what I need to do next though. It is still failing. Ref: https://github.com/ruby-oauth/oauth2/actions/runs/17692969800/job/50291221524#step:3:129 IMO, these licenses are all compatible with MIT, especially the ones that are MIT. 😆 Perhaps we need to configure the MIT license as compatible with other licenses? |
Yes exactly! We need to config the |
|
Ruby license is a license, and many of the standard ruby libraries (default, bundled, core) use it! |
|
Also, the ruby license doesn't have a standard license header... is that a problem? |
|
@kezhenxu94 Where can I find documentation on the difference between |
https://www.apache.org/legal/resolved.html#category-b this is ASF specific, the weak-compatibility might not be applicable to other license, though. |
In terms of dependency license check, that’s not a problem. For license header, we can just use the spdx id as the license header. |
I don’t see any email, did you sent to dev@skywalking.apache.org? |
Yes. I will send it again! |
|
Sent another request. Subject |
Uh oh!
There was an error while loading. Please reload this page.