Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17359: Move Zk Arg parsing into Java Code #2593

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Jul 24, 2024

https://issues.apache.org/jira/browse/SOLR-17359

Description

Migrate arg parsing for ZK commands into Java code

Solution

Had to add a ZkToolHelp to handle some of the global help output.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

@github-actions github-actions bot added documentation Improvements or additions to documentation docker Docker image labels Jul 25, 2024
@epugh epugh marked this pull request as ready for review July 25, 2024 18:56
@epugh epugh requested review from janhoy and gerlowskija July 25, 2024 18:58
@epugh
Copy link
Contributor Author

epugh commented Jul 25, 2024

Okay, I changed the short cut "-s" to mean Solr URL instead of "shards". however, in 9x "-s" means shards.. I am thinking that maybe I change allt he tests to use "--shards", and when I backport to 9x, I don't make "-s" mean solr url, but leave it as shards parameter?

@epugh
Copy link
Contributor Author

epugh commented Jul 31, 2024

FYI, for folks tracking this, @rahulgoswami has started testing this PR on Windows! Thanks @rahulgoswami ... He has validated start, stop and restart and then will start digging into the ZK commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:cli docker Docker image documentation Improvements or additions to documentation start-scripts tests
Projects
None yet
1 participant