feat: set workload image pull secrets #7891
Conversation
|
|
||
| func BuildImagePullSecrets() []corev1.LocalObjectReference { | ||
| secrets := make([]corev1.LocalObjectReference, 0) | ||
| secretsVal := viper.GetString(constant.KBImagePullSecrets) |
There was a problem hiding this comment.
@leon-inf , should we add imagePullSecrets field in ComponentVersion?
There was a problem hiding this comment.
It is a runtime resource about specific k8s cluster, and is not suitable to define in ComponentVersion.
There was a problem hiding this comment.
Yeah, then should it be defined in Cluster?
There was a problem hiding this comment.
It's more reasonable as a global config for KB or k8s cluster.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7891 +/- ##
==========================================
- Coverage 64.84% 64.81% -0.04%
==========================================
Files 345 345
Lines 43100 43119 +19
==========================================
- Hits 27947 27946 -1
- Misses 12693 12718 +25
+ Partials 2460 2455 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/approve to trigger test |
|
/cherry-pick release-0.9 |
|
🤖 says: cherry pick action finished successfully 🎉! |
(cherry picked from commit 0bbc36b)
Support to set image pull secrets for data plane workload:
For user, if they use a private image registry and need a secret to pull, they should create the image pull secret first in the namespace.
Now, the secret name is same with the control plane image pull secrets that specified when install KubeBlocks.