Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add codespace devcontainer #19557

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ChichiCaleb
Copy link

@ChichiCaleb ChichiCaleb commented Aug 15, 2024

Description

Argocd development workflow is great and straightforward, however one might one to quickly start developing without spending much time setting up local cluster and necessary configuration.

Secondly, the developers local development environment might not have sufficient memory and capacity that will ensure seamless development, hence the need for a more efficient and ready to go environment

Requirement

Enable Codespace on forked repo and sync with your local vscode

export CODESPACE=true

Can now run relevant make commands

Fixes #19556

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: ChichiCaleb <chichiuchenna@gmail.com>
@ChichiCaleb ChichiCaleb requested a review from a team as a code owner August 15, 2024 18:08
Copy link

bunnyshell bot commented Aug 15, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

bunnyshell bot commented Aug 15, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.81%. Comparing base (47bcb09) to head (7337fd2).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19557      +/-   ##
==========================================
- Coverage   55.83%   55.81%   -0.02%     
==========================================
  Files         316      316              
  Lines       43743    43743              
==========================================
- Hits        24422    24416       -6     
- Misses      16768    16773       +5     
- Partials     2553     2554       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ChichiCaleb and others added 6 commits August 16, 2024 05:28
Signed-off-by: ChichiCaleb <chichiuchenna@gmail.com>
Signed-off-by: ChichiCaleb <chichiuchenna@gmail.com>
Signed-off-by: ChichiCaleb <chichiuchenna@gmail.com>
Signed-off-by: ChichiCaleb <chichiuchenna@gmail.com>
Signed-off-by: ChichiCaleb <chichiuchenna@gmail.com>
@ChichiCaleb ChichiCaleb requested a review from a team as a code owner August 17, 2024 15:58
@christianh814
Copy link
Member

@csantanapr Wasn't this something you've worked on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add support for codespace devcontainer
2 participants