Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): adjust transform origin in application-resource-tree component #20180

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix(ui): adjust transform origin in application-resource-tree component #20180

merged 1 commit into from
Oct 7, 2024

Conversation

srikanth597
Copy link
Contributor

@srikanth597 srikanth597 commented Oct 1, 2024 •
edited
Loading

Closes #19519

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@srikanth597 srikanth597 requested a review from a team as a code owner October 1, 2024 10:07
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 1, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 1, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@srikanth597
Copy link
Contributor Author

Tested On a Regular device of 15-16 inches
image

@srikanth597
Copy link
Contributor Author

Tested on Monitor
image

@srikanth597 srikanth597 mentioned this pull request Oct 1, 2024
Closed
14 tasks
nitishfy
nitishfy suggested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the commits.

@srikanth597
Copy link
Contributor Author

Hi @nitishfy I am not sure if I have understood it correctly, but I have already signed the commits in the new PR, is that not correct?
image

@crenshaw-dev
Copy link
Member

crenshaw-dev commented Oct 1, 2024 •
edited
Loading

@srikanth597 the naming is unfortunate. "Signed commits" are cryptographically signed (which you've done). "Signed-off commits" just have an extra bit of text on the commit message. You can check the details of the failed "DCO" check for instructions on how to sign off commits.

@nitishfy
Copy link
Contributor

nitishfy commented Oct 2, 2024

Hi @nitishfy I am not sure if I have understood it correctly, but I have already signed the commits in the new PR, is that not correct? image

Simply ammend it using git commit --amend --signoff command

@srikanth597 srikanth597 closed this Oct 2, 2024
@srikanth597
fix(ui): adjust transform origin in application resource tree
6fe375b 
Signed-off-by: srikanth597 <alapatisrikanth597@gmail.com>
@srikanth597 srikanth597 reopened this Oct 2, 2024
@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 2, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@bunnyshell Bunnyshell
Copy link

bunnyshell bot commented Oct 2, 2024 •
edited
Loading

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@srikanth597
Copy link
Contributor Author

@nitishfy i have cleared the DCO check

nitishfy
nitishfy approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@srikanth597
Copy link
Contributor Author

@nitishfy PR is still OPEN, any action item on me ?
do i need to update branch

@gdsoumya gdsoumya merged commit 7718af1 into argoproj:master Oct 7, 2024
22 of 39 checks passed
christianh814
christianh814 reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@christianh814 christianh814 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

ALIHAMZA99 pushed a commit to ALIHAMZA99/argo-cd that referenced this pull request Oct 10, 2024
@srikanth597 @ALIHAMZA99
fix(ui): adjust transform origin in application resource tree (argopr…
e1bacf4 
…oj#20180)

Signed-off-by: srikanth597 <alapatisrikanth597@gmail.com>
Signed-off-by: alnoor <alihamzanoor99@gmail.com>
austin5219 pushed a commit to austin5219/argo-cd that referenced this pull request Oct 16, 2024
@srikanth597 @austin5219
fix(ui): adjust transform origin in application resource tree (argopr…
224010c 
…oj#20180)

Signed-off-by: srikanth597 <alapatisrikanth597@gmail.com>
Signed-off-by: austin5219 <3936059+austin5219@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianh814 christianh814 christianh814 left review comments

@nitishfy nitishfy nitishfy approved these changes

@gdsoumya gdsoumya gdsoumya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Floating view toolbar covers cloud and first two resource boxes in Network View
5 participants
@srikanth597 @crenshaw-dev @nitishfy @christianh814 @gdsoumya