fix: set loading to false on error. Fixes #72

arkokoley · Aug 1, 2021 · f17c532 · f17c532
1 parent b26c12f
commit f17c532
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -50,8 +50,8 @@
     "worker-loader": "^3.0.1"
   },
   "peerDependencies": {
-    "vue": "^2.6.11",
-    "pdfjs-dist": "2.5.207"
+    "pdfjs-dist": "2.5.207",
+    "vue": "^2.6.11"
   },
   "engines": {
     "node": ">=10"

diff --git a/src/Pdfvuer.vue b/src/Pdfvuer.vue
@@ -49,6 +49,7 @@
   }
 
   export default {
+    createLoadingTask: createLoadingTask,
     components: {
       resizeSensor
     },
@@ -162,9 +163,6 @@
             textLayerFactory: textLayer,
             annotationLayerFactory: annotationLayer,
           });
-          self.loading = false;
-          self.$emit('loading', false);
-
           // Associates the actual page with the view, and drawing it
           self.pdfViewer.setPdfPage(pdfPage);
           // Set up a scrollPageIntoView function for our links
@@ -178,7 +176,14 @@
           self.pdfLinkService.setViewer(viewer);
           self.pdfFindController.setDocument(self.pdf);
           self.drawScaled(self.scale);
-        }).catch(err => self.$emit('error', err))
+
+          self.loading = false;
+          self.$emit('loading', false);
+        }).catch(err => {
+          self.$emit('error', err)
+          self.loading = false
+          self.$emit('loading', false);
+        })
     },
     beforeDestroy() {
       var self = this;