Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove flake8 from githook #109

Merged
merged 3 commits into from
Jun 14, 2019
Merged

remove flake8 from githook #109

merged 3 commits into from
Jun 14, 2019

Conversation

geoalgo
Copy link
Contributor

@geoalgo geoalgo commented Jun 14, 2019

Description of changes:
remove flake8 from githook

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@geoalgo geoalgo requested a review from jaheba June 14, 2019 13:12
@lostella
Copy link
Contributor

Should this file be checked in at all? Maybe not, and we should be modifying dev_setup.sh instead

@szha
Copy link
Member

szha commented Jun 14, 2019

Job PR-109/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-109/1/index.html

@geoalgo
Copy link
Contributor Author

geoalgo commented Jun 14, 2019

Should this file be checked in at all? Maybe not, and we should be modifying dev_setup.sh instead

Currently, the developer instructions are async as a hook with flake8 is added and it should not.
I propose to first do this (removing flake8) and then revisit the dev_setup.sh if this is needed.

@lostella
Copy link
Contributor

Currently, the developer instructions are async as a hook with flake8 is added and it should not.
I propose to first do this (removing flake8) and then revisit the dev_setup.sh if this is needed.

Sorry, got confused :-)

lostella
lostella previously approved these changes Jun 14, 2019
@szha
Copy link
Member

szha commented Jun 14, 2019

Job PR-109/2 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-109/2/index.html

@szha
Copy link
Member

szha commented Jun 14, 2019

Job PR-109/3 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-109/3/index.html

@geoalgo geoalgo merged commit a52a9d2 into master Jun 14, 2019
@lostella lostella deleted the remove-flake8 branch June 14, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants