fix(coding-agent): remove spacing artifacts for suppressed custom tool renders#1719
Merged
badlogic merged 2 commits intobadlogic:mainfrom Mar 2, 2026
Merged
Conversation
badlogic
added a commit
that referenced
this pull request
Mar 2, 2026
Owner
|
Cheers! |
Contributor
Author
@badlogic my pleasure! thanks for merging this :) here's what it enabled me to do as an extension now FYI
prior to this fix it was appending 5 empty new lines below the component (one per file read) which made the UI much worse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR fixes interactive transcript spacing when custom tool renderers intentionally suppress per-call output.
Use case: extensions that group contiguous tool calls into a single UI block (for example grouped file reads) should be able to hide individual tool entries without leaving empty rows or extra spacing.
Related to #1715 (approval issue, now closed).
Changes
renderCall?: (...) => Component | undefinedrenderResult?: (...) => Component | undefinedToolExecutionComponentso suppressed custom tool output can render as true zero-height (no leftover transcript footprint).undefined.Scope
This is an intentionally minimal, non-breaking fix for extension-driven grouped tool UIs.
A fuller transcript-level grouping/coalescing API can be done separately.
Validation
npm run check./test.sh