feat(tui): add non-capturing overlays with focus control#1916
Open
nicobailon wants to merge 1 commit intobadlogic:mainfrom
Open
feat(tui): add non-capturing overlays with focus control#1916nicobailon wants to merge 1 commit intobadlogic:mainfrom
nicobailon wants to merge 1 commit intobadlogic:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for the delay, this closes #1355.
The core implementation is just +46 lines added to
tui.ts(showOverlay,hideOverlay,compositeOverlays). The rest are tests and examples.Overlays now have a
nonCapturingoption so they don't steal keyboard focus and you can switch focus between them.New OverlayHandle methods:
focus(),unfocus(),isFocused()to control which overlay receives input and bring it to the front.Added manual test commands in
examples/extensions/overlay-qa-tests.ts(/overlay-passive,/overlay-focus,/overlay-streaming). We could removeoverlay-qa-tests.tsafter testing manually to reduce bloat, or keep those around for examples.Screen.Recording.2026-03-06.mp4