Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean laplace results #563

Merged
merged 5 commits into from
Aug 27, 2022
Merged

clean laplace results #563

merged 5 commits into from
Aug 27, 2022

Conversation

aloctavodia
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2022

Codecov Report

Merging #563 (be41dd5) into main (505fbb3) will increase coverage by 0.01%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   86.01%   86.02%   +0.01%     
==========================================
  Files          32       32              
  Lines        2689     2691       +2     
==========================================
+ Hits         2313     2315       +2     
  Misses        376      376              
Impacted Files Coverage Δ
bambi/backend/links.py 96.15% <0.00%> (ø)
bambi/backend/pymc.py 82.18% <100.00%> (+0.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@tomicapretto tomicapretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! The only thing I would change is the docstring for the _run_laplace() method

aloctavodia and others added 2 commits August 27, 2022 11:21
It's not part of the method signature.
@tomicapretto
Copy link
Collaborator

@aloctavodia feel free to merge if you don't plan to add anything else :)

@aloctavodia aloctavodia merged commit e51a992 into bambinos:main Aug 27, 2022
@aloctavodia aloctavodia deleted the clean_laplace branch August 27, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants