Handle output in stderr gracefully when discovering tests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've update the PR according to your feedback after a rebase from master. Would you mind taking another look? |
| @@ -23,6 +24,11 @@ def main(): | |||
| if dialog.status == dialog.CANCEL: | |||
| sys.exit(1) | |||
|
|
|||
| if project.errors: | |||
| dialog = IgnorableTestLoadErrorDialog(root, project.render_errors()) | |||
There was a problem hiding this comment.
render_errors() has been removed, so this needs to be cleaned up.
| trace, | ||
| button_text='Retry', | ||
| cancel_text='Quit', | ||
| ) | ||
|
|
||
| def cancel(self, event=None): | ||
| self.parent.destroy() |
There was a problem hiding this comment.
Good catch noticing this one; see FailedTestDialog for what the implementation should be.
|
I've updated the PR to reflect your feedback. It now has support for |
freakboy3742
added a commit
that referenced
this pull request
Jul 9, 2013
Handle output in stderr gracefully when discovering tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovering tests did fail as soon as there is output in
stderrduring the discovery process. This happened even when the output is just aINFOlevel log. To prevent this from happening, I have changed theProjectmodel to collect the errors and only raise an exception if no test can be found and there are errors instderr. Otherwise,stderrwill be displayed in a stack trace dialog but allow to continue with the discovered tests.I added a few tests for the discovery message. I am not quite sure about the format or your preference, so please let me know if there's anything that need to be changed. Also, I am not sure if the
requirements_test.txtis the right way to deal with test-only dependencies. How do you want to handle that?