Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consider repo config fallback option #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PierreJeanjacquot
Copy link

Repo config fallback option when consider file is not found

The consider file feature is great, but you must set a configure file in all your repositories, whether it's a mono-repo or not.
With many repositories (mono-repo and standard repo), this can be tedious. We went into this issue while refactoring our codebase into mono-repos.

This PR adds the option PLUGIN_CONSIDER_REPO_CONFIG to allow falling back to the drone configuration of the repository when the server defines a PLUGIN_CONSIDER_FILE but the repository does not have one.

@mach6
Copy link
Contributor

mach6 commented Jan 9, 2024

you must set a configure file in all your repositories, whether it's a mono-repo or not.

Have you looked at the config option PLUGIN_ALLOW_LIST_FILE? This is how you control this behavior.

@PierreJeanjacquot
Copy link
Author

Yes, that's a good point, thank you @mach6!
Unfortunately, the development team has no access to configure the drone server deployment in our organization, which adds some friction in the process of keeping the drone configuration up to date...
I'll check what suits the best for us 👍

@PierreJeanjacquot
Copy link
Author

Update, I finally got access to drone deployment to update the allow list and I didn't need the fallback anymore 😃
I leave the PR open but feel free to close it if you think this feature isn't needed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants