Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-17765 & PM-17767 Adjust spacing in vault screen and adjust account switcher icon size and minimum row height #4661

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

dseverns-livefront
Copy link
Collaborator

@dseverns-livefront dseverns-livefront commented Jan 31, 2025

🎟️ Tracking

PM-17765
PM-17767

📔 Objective

  • Fix the spacing in the vault screen between the start of the content and the items, move the 16.dp padding between items to the end of "each" section so for conditional content it will only be applied if needed.
  • Change icon size in account switcher drop down and set a minimum row height for each option per the desing.

📸 Screenshots

OLD | NEW
image

image

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa3d884ee-41d2-40d8-8c39-d6673fbe642e

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.38%. Comparing base (de558bf) to head (4e1f27c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4661   +/-   ##
=======================================
  Coverage   88.38%   88.38%           
=======================================
  Files         607      607           
  Lines       41105    41106    +1     
  Branches     5773     5773           
=======================================
+ Hits        36330    36331    +1     
  Misses       2757     2757           
  Partials     2018     2018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dseverns-livefront dseverns-livefront added this pull request to the merge queue Jan 31, 2025
@dseverns-livefront
Copy link
Collaborator Author

THANKS @david-livefront !

Merged via the queue into main with commit 2b79cc9 Jan 31, 2025
9 checks passed
@dseverns-livefront dseverns-livefront deleted the PM-17767-PM-17765-pixel-adjustments branch January 31, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants