Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vault favorites spacing #4665

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

david-livefront
Copy link
Collaborator

@david-livefront david-livefront commented Jan 31, 2025

🎟️ Tracking

N/A

📔 Objective

This PR fixes a spacing issue between card items in the vault screen favorites.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront force-pushed the fix-vault-favorites-spacing branch from de72cb0 to 6219df4 Compare January 31, 2025 17:53
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailse7cd6f95-eb2d-4e38-bd2b-ad0939e6f97b

Great job, no security vulnerabilities found in this Pull Request

@david-livefront
Copy link
Collaborator Author

Thanks @dseverns-livefront

@david-livefront david-livefront added this pull request to the merge queue Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (2b79cc9) to head (6219df4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4665   +/-   ##
=======================================
  Coverage   88.39%   88.39%           
=======================================
  Files         607      607           
  Lines       41084    41084           
  Branches     5773     5773           
=======================================
  Hits        36315    36315           
  Misses       2751     2751           
  Partials     2018     2018           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

auto-merge was automatically disabled January 31, 2025 18:19

Pull Request is not mergeable

Merged via the queue into main with commit 38c9d6c Jan 31, 2025
9 checks passed
@david-livefront david-livefront deleted the fix-vault-favorites-spacing branch January 31, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants