release-24.1.3-rc: kvclient: don't drop ambiguous errors on incompatible transport #127372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #121691 on behalf of @andrewbaptist.
/cc @cockroachdb/release
Previously in the case of a NLHE with an incompatible transport we would
exit the retry loop immediately and return the error without checking if
there were any ambiguous or replica unavailable errors. This had a risk
of losing an ambiguous error if the retry later succeeded and returning
an incorrect result to the caller.
Epic: none
Release note: None
Release justification: This fixes an uncommon situation where backups can fail due to node outages incorrectly resulting in a ambiguous error. This will otherwise introduce a new failure mode that may cause customer escalations.