Location via proxy:   [ UP ]  
[Report a bug]   [Manage cookies]                
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.1.3-rc: kvclient: don't drop ambiguous errors on incompatible transport #127372

Merged

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 17, 2024

Backport 1/1 commits from #121691 on behalf of @andrewbaptist.

/cc @cockroachdb/release


Previously in the case of a NLHE with an incompatible transport we would
exit the retry loop immediately and return the error without checking if
there were any ambiguous or replica unavailable errors. This had a risk
of losing an ambiguous error if the retry later succeeded and returning
an incorrect result to the caller.

Epic: none

Release note: None


Release justification: This fixes an uncommon situation where backups can fail due to node outages incorrectly resulting in a ambiguous error. This will otherwise introduce a new failure mode that may cause customer escalations.

Previously in the case of a NLHE with an incompatible transport we would
exit the retry loop immediately and return the error without checking if
there were any ambiguous or replica unavailable errors. This had a risk
of losing an ambiguous error if the retry lt ater succeeded and returning
an incorrect result to the caller.

Epic: none

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-24.1.3-rc-121691 branch from d0f03c1 to 6634b51 Compare July 17, 2024 17:21
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 17, 2024 17:21
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 17, 2024
Copy link
Author

blathers-crl bot commented Jul 17, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Jul 17, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andrewbaptist
Copy link
Collaborator

@arulajmani can you tag this one - it was a clean backport. Thanks!

Also #127369 and #127371

@andrewbaptist andrewbaptist merged commit 9e10212 into release-24.1.3-rc Jul 29, 2024
19 of 20 checks passed
@andrewbaptist andrewbaptist deleted the blathers/backport-release-24.1.3-rc-121691 branch July 29, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants