Raise default remediation, categorize checks #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Categorize checks loosely based on the CSSLint wiki[1]. The most obvious departure was categorizing Performance rules as Bug Risk checks. 1: https://github.com/CSSLint/csslint/wiki/Rules Default remediation was at an abysmal 500, upped it to the "trivial" baseline for now and built a small class allowing us to easily override these later. I chose keyword arguments in the CheckDetails class so we can easily create an override object for one, the other, or both of categories and remediation points.
0b5b203 to
9da9360
Compare
|
Ignoring CC issues.
|
|
|
||
| def self.all | ||
| @all ||= { | ||
| "net.csslint.Adjoiningclasses" => new(categories: "Compatability"), |
There was a problem hiding this comment.
should these go in a constant? Maybe of the format
"net.csslint.Adjoiningclasses" => { categories: "Compatability", }and then in fetch below you can do
new(all.fetch(check_name, {}))There was a problem hiding this comment.
Yes, great suggestion.
|
LGTM |
| module Engine | ||
| class CSSlint | ||
| # https://github.com/CSSLint/csslint/wiki/Rules | ||
| class CheckDetails |
There was a problem hiding this comment.
It seems like the major function of this class at present is to get the category for an issue.
What do you think about having a category class instead, and have it initialize with a check?
Then, in the CSSLint or an Issue class, we can have
def categories
Category.new(check_name)
end
def remediation_points
DEFAULT_REMEDIATION_POINTS
end
pbrisbin
added a commit
that referenced
this pull request
Dec 7, 2015
Raise default remediation, categorize checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default remediation was at an abysmal 500, upped it to the "trivial" baseline
for now and built a small class allowing us to easily override later.
Categorized checks loosely based on the CSSLint wiki[1]. The most obvious
departure was categorizing Performance rules as Bug Risk checks.
I chose keyword arguments in CheckDetails so we can easily create an override
object for one, the other, or both of categories and remediation points.
1: https://github.com/CSSLint/csslint/wiki/Rules
/cc @codeclimate/review