Exclude and include paths. #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def build_files_with_inclusions(inclusions) | ||
| inclusions.map do |include_path| | ||
| if include_path =~ %r{/$} |
There was a problem hiding this comment.
this might be more readable as include_path.ends_with?("/"). WDYT?
There was a problem hiding this comment.
It would be, but we're not using activesupport here and keeping things light might be a higher priority here.
|
@fhwang re: the CC errors. We probably want to import a |
|
@gordondiggs sure, any thoughts on which other repo? |
|
@fhwang this one looks good https://github.com/codeclimate/codeclimate/blob/master/.rubocop.yml. Looks like we also exclude spec |
|
@gordondiggs take a look now? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.